-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dimension Co-ordinates incorectly saving _FillValue attribute #1865
Comments
Please add the label "CF conventions" to this issue |
Please take a look at the discussion in #1598. You can use |
Thanks. |
If you have ideas for improving this further (even documentation), please do speak up. |
My apologies for having to re-open the issue, I should have tried the fix before closing. I get the following error after changing my last line to:
Do we just need to append '_FillValue' to the list of
|
@shoyer, I'll look at the documentation once this is resolved and make a PR. |
* Add '_FillValue' to set of valid_encodings for netCDF4 backend * Add additional omit_fill_value tests Add additional tests to prevent future regression of setting _FillValue to None when using the encoding kwarg in to_netcdf. * Fix additional omit_fill_value tests Remove copy/paste line that shouldn't have been in a test. Add additional asserts. Fix indentation. * Fix scipy failure in additional omit_fill_value tests * Added bug-fix documentation for #1865
Code Sample, a copy-pastable example if possible
Problem description
According to the last sentence of the first paragraph of 2.5.1. Missing data, valid and actual range of data in NetCDF Climate and Forecast (CF) Metadata Conventions 1.7:
When I use the conformance checker it issues an INFO message to this point for the co-ordinate variables.
Output of CF-Checker follows...
Expected Output
Co-ordinate variables should not store a _FillValue attribute
Output of
xr.show_versions()
INSTALLED VERSIONS
commit: None
python: 3.6.4.final.0
python-bits: 64
OS: Linux
OS-release: 4.14.15-1-ARCH
machine: x86_64
processor:
byteorder: little
LC_ALL: None
LANG: en_US.UTF-8
LOCALE: en_US.UTF-8
xarray: 0.10.0
pandas: 0.22.0
numpy: 1.14.0
scipy: 1.0.0
netCDF4: 1.3.1
h5netcdf: 0.5.0
Nio: None
bottleneck: 1.2.1
cyordereddict: None
dask: 0.16.1
matplotlib: 2.1.2
cartopy: None
seaborn: None
setuptools: 38.4.0
pip: 9.0.1
conda: None
pytest: None
IPython: None
sphinx: None
The text was updated successfully, but these errors were encountered: