Use base ImportError not MoudleNotFoundError when trying to see if the (

#6154) modules load
pydata · Jan 11, 2022 · 5c08ab2 · 5c08ab2
1 parent 9226c7a
commit 5c08ab2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/xarray/backends/h5netcdf_.py b/xarray/backends/h5netcdf_.py
@@ -35,7 +35,10 @@
     import h5netcdf
 
     has_h5netcdf = True
-except ModuleNotFoundError:
+except ImportError:
+    # Except a base ImportError (not ModuleNotFoundError) to catch usecases
+    # where errors have mismatched versions of c-dependencies. This can happen
+    # when developers are making changes them.
     has_h5netcdf = False
 
 

diff --git a/xarray/backends/netCDF4_.py b/xarray/backends/netCDF4_.py
@@ -33,7 +33,10 @@
     import netCDF4
 
     has_netcdf4 = True
-except ModuleNotFoundError:
+except ImportError:
+    # Except a base ImportError (not ModuleNotFoundError) to catch usecases
+    # where errors have mismatched versions of c-dependencies. This can happen
+    # when developers are making changes them.
     has_netcdf4 = False