-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize a name for this sphinx theme #102
Comments
@jorisvandenbossche can you think of any names other than:
And re: these two, I think the two questions to answer are:
|
To be able to make an actual release, and upload to PyPI (so people can rely on this without needing to install from git master), we need to decide on a name. This will also break once everybody who is already using the theme, since people will need to update their So originally the theme was called "pandas-sphinx-theme". Since we want to have it broader than pandas, it was proposed to make this "pydata-sphinx-theme". Personally, my reservation for this was that this sounds as this is thé sphinx theme for pydata projects, while there are of course many themes in use in the community (but in the end I don't mind that much if people prefer this). Therefore I made it a bit more specific to "pydata-bootstrap-sphinx-theme" (a bootstrap theme for the pydata community). But that is a long name .. Alternatively, we could also just pick another "random" name that is not directly using to pandas/pydata/bootstrap in the name, such as .. "alexandria-sphinx-theme" (with a link to the old library in egypt). Or other ideas? cc @stijnvanhoey @choldgraf (jupyterhub/book) @chrisjsewell (myst) @bryevdv (bokeh) @HTenkanen (Python-GIS-book) @martinRenou (ipycanvas) @stevedodson (eland) (tagging the users that I know of or found by github search, since you will be affected (need to update conf.py), and might have an opinion on a name ;-)) |
@choldgraf typed my comment a while ago before I saw yours: regarding "brand" owning by NumFOCUS, that's a good question to which I also don't know the answer, so something to check. |
Let's do a quick poll (assuming the pydata brand issue is no problem, we can check in the mean time). Putting the options in the following comments, and you can use github's "reaction" emoticons to vote (multiple votes allowed, you can also add your own suggestion) |
pydata-bootstrap-sphinx-theme |
pydata-sphinx-theme |
bootstrap-sphinx-theme |
alexandria-sphinx-theme |
@jorisvandenbossche Thanks for the heads up! If possible, I would vote for something like |
I think I also have a slight preference for |
I really like |
Note, given the preference for "pydata-sphinx-theme", I will drop my objections, and I have contacted NumFOCUS about using the name in the meantime (but no answer yet) |
OK, I got reply from NumFOCUS that they have no issues with using "pydata" in the name. |
OK, package has been renamed, and version 0.1.0 released on PyPI: https://pypi.org/project/pydata-sphinx-theme/ (still need to add a description there :)) Important note: you will all need to update your |
amazing! |
cheers @jorisvandenbossche 😄 @choldgraf, we now need to go through all our EBP packages, remove the docs/requirements.txt (and its use in the RTD and CircleCI yamls), and add this package to the |
Readthedocs is also updated: https://pydata-sphinx-theme.readthedocs.io/en/latest/ |
And available on conda-forge now as well: https://anaconda.org/conda-forge/pydata-sphinx-theme |
Important note: you will all need to update your
conf.py
entry forhtml_theme = "pandas_sphinx_theme"
->html_theme = "pydata_sphinx_theme"
We should update the RTD url so that it isn't "pandas" specific - to do that, we'll need to manually update the URL (easiest way is to just delete and re-create the RTD site).
Before we do that - are we happy with the final name?
pydata-bootstrap-sphinx-theme
?I think the other obvious option would be just
pydata-sphinx-theme
. I appreciate the specificity of the former, and the readability of the latter. What do you all think?The text was updated successfully, but these errors were encountered: