Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

be more verbose in the 102 deprecation notice #5505

Merged
merged 1 commit into from
Oct 25, 2020
Merged

Conversation

reaperhulk
Copy link
Member

No description provided.

"cryptography you need to upgrade to a newer version of "
"OpenSSL. For this version only you can also set the "
"environment variable CRYPTOGRAPHY_ALLOW_OPENSSL_102 to "
"allow OpenSSL 1.0.2."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have not included this in previous OpenSSL version droppings, and instead referred people to the docs. Why now?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I've fielded at least one question on StackOverflow where it turns out they broke their pip (due to the pyOpenSSL + cryptography on older pip/Python). They couldn't find the docs because we only keep them around for one version and I'd rather make it obvious how to fix it directly in the error.

@alex alex merged commit bf4b962 into master Oct 25, 2020
@alex alex deleted the reaperhulk-patch-2 branch October 25, 2020 23:12
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants