Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the summary table format #407

Merged
merged 16 commits into from
Feb 20, 2021
Merged

Change the summary table format #407

merged 16 commits into from
Feb 20, 2021

Conversation

heimengqi
Copy link
Contributor

@heimengqi heimengqi commented Feb 12, 2021 •
edited by kbattocchi
Loading

Fixes #403.

@heimengqi heimengqi mentioned this pull request Feb 17, 2021
Closed
@heimengqi heimengqi mentioned this pull request Feb 17, 2021
Closed
kbattocchi
kbattocchi reviewed Feb 18, 2021
View reviewed changes
Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, just a few minor suggestions. But shouldn't there also be updates to the notebooks that reflect the revised shapes?

econml/_cate_estimator.py Outdated Show resolved Hide resolved
econml/_cate_estimator.py Outdated Show resolved Hide resolved
econml/inference/_inference.py Outdated Show resolved Hide resolved
econml/inference/_inference.py Outdated Show resolved Hide resolved
econml/inference/_inference.py Outdated Show resolved Hide resolved
econml/inference/_inference.py Outdated Show resolved Hide resolved
@heimengqi
Copy link
Contributor Author

I expect Miruna will touch almost all the notebooks, so I will update notebooks after rebase on Miruna's PR to avoid annoying conflicts.

kbattocchi
kbattocchi requested changes Feb 19, 2021
View reviewed changes
Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test showing that this actually fixes #403.

kbattocchi
kbattocchi approved these changes Feb 19, 2021
View reviewed changes
Copy link
Collaborator

@kbattocchi kbattocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a few minor suggestions, but this looks good.

econml/inference/_inference.py Outdated Show resolved Hide resolved
econml/inference/_inference.py Outdated Show resolved Hide resolved
econml/inference/_inference.py Outdated Show resolved Hide resolved
econml/tests/test_inference.py Outdated Show resolved Hide resolved
heimengqi and others added 7 commits February 19, 2021 17:45
@heimengqi
fix test failure because of merge from master and update the right va…
1c6d77b 
…riable names for dowhy wrapper
@heimengqi
update notebooks to show the new summary format
bf7b674
@heimengqi @kbattocchi
Update econml/tests/test_inference.py
1f23dc4 
Co-authored-by: Keith Battocchi <kebatt@microsoft.com>
@heimengqi @kbattocchi
Update econml/inference/_inference.py
59a454e 
Co-authored-by: Keith Battocchi <kebatt@microsoft.com>
@heimengqi @kbattocchi
Update econml/inference/_inference.py
02347e5 
Co-authored-by: Keith Battocchi <kebatt@microsoft.com>
@heimengqi @kbattocchi
Update econml/inference/_inference.py
22cfbec 
Co-authored-by: Keith Battocchi <kebatt@microsoft.com>
@heimengqi
linting
712b1ab
@heimengqi heimengqi merged commit a9330c0 into master Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbattocchi kbattocchi kbattocchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot pickle InferenceResults
2 participants
@heimengqi @kbattocchi