Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT]: Remove tests from wheel distro #2277

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

echedey-ls
Copy link
Contributor

  • Closes Exclude unnecssary data from pvlib packaging #2271
  • I am familiar with the contributing guidelines
  • [ ] Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • [ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

My biggest fear is that setuptools is caching things so please make a fresh local test. So far everything looks great to me:

  • Tests and test data included in sdist
  • Neither tests nor test data included in bdist

Partially addresses #1056 by moving all data files exclusively used for testing into pvlib/tests/data

Whatsnew already updated with quantified sizes from wheel both zipped and once extracted compared against v0.11.1.

@echedey-ls
Copy link
Contributor Author

I haven't checked whether conda-forge will complain because I don't have a clue on how it tests packages, from sdist, bdist, ... Maybe anyone more knowledgable can foretell about that.

@kandersolar
Copy link
Member

I think there shouldn't be any problem with conda-forge. It doesn't run the tests, nor does it rely on the presence of the test data files. Additionally, the process is entirely driven by the sdist (not wheel) files on PyPI anyway, so if we only change the wheel files, I think there can't be an issue.

For reference, here's the conda-forge recipe for pvlib-python: https://github.com/conda-forge/pvlib-python-feedstock/blob/main/recipe/meta.yaml

Copy link
Member

@AdamRJensen AdamRJensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A brief review from my phone. But I like it!

docs/sphinx/source/whatsnew/v0.11.2.rst Outdated Show resolved Hide resolved
Co-authored-by: Adam R. Jensen <39184289+AdamRJensen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude unnecssary data from pvlib packaging
3 participants