Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT]: Partially move test_conftest to test__deprecation #2262

Merged
merged 3 commits into from
Oct 19, 2024

Conversation

echedey-ls
Copy link
Contributor

@echedey-ls echedey-ls commented Oct 15, 2024

Rearranging things for future selfs: #2237 (comment)

@echedey-ls
Copy link
Contributor Author

Shall I add a whatsnew entry for #2237? Under a section for maintenance.

@kandersolar kandersolar added this to the v0.11.2 milestone Oct 16, 2024
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Yes to a whatsnew entry, and I like the idea of a Maintenance section.

@kandersolar kandersolar merged commit 254d82f into pvlib:main Oct 19, 2024
26 checks passed
@kandersolar
Copy link
Member

Thanks @echedey-ls!

@echedey-ls echedey-ls deleted the move-conftest-to-_deprecated branch October 19, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants