-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Infer spectral models correctly #2253
base: main
Are you sure you want to change the base?
[BUG]: Infer spectral models correctly #2253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we're trying too hard to help. I'm inclined to default to the no_loss
model if parameters are not found, regardless of Technology
, Material
or weather
.
Or just do away with the inference altogether and set to no_loss
if spectral_model=None
Co-Authored-By: Cliff Hansen <5393711+cwhanse@users.noreply.github.com>
|
|
[ ] Updates entries indocs/sphinx/source/reference
for API changes.docs/sphinx/source/whatsnew
for all changes. Includes link to the GitHub Issue with:issue:`num`
or this Pull Request with:pull:`num`
. Includes contributor name and/or GitHub username (link with:ghuser:`user`
).remote-data
) and Milestone are assigned to the Pull Request and linked Issue.Fix #2017 - note the approach may have been different. In this case, spectral inference has been deferred until weather is known, in order to take its available parameters for the inference.
Tested for script:
Code cleaned up from #2017
Still haven't added tests, please let me know what you think about the behaviour first.