Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GH action versions #2223

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

AdamRJensen
Copy link
Member

@AdamRJensen AdamRJensen commented Sep 25, 2024

Duplicate of #2218

  • I am familiar with the contributing guidelines
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

The current versions of the tools used in the GH actions are outdated and are emitting warnings:

image

image

Used the replace-all function in Visual Studio Code that handles all files in a repository link

@echedey-ls
Copy link
Contributor

echedey-ls commented Sep 25, 2024

You may want to compare against #2218

P.S.: when did you become part of the VSCode gang? 🤩

@AdamRJensen
Copy link
Member Author

AdamRJensen commented Sep 25, 2024

You may want to compare against #2218

P.S.: when did you become part of the VSCode gang? 🤩

Here I was all proud of using VSCode and then it's a duplicate PR - sorry @echedey-ls. I think we should merge either one of the two (they're identical now). I don't want to see warnings and the old actions are security supported any longer and we should take security seriously.

@AdamRJensen AdamRJensen marked this pull request as ready for review September 25, 2024 16:11
@echedey-ls
Copy link
Contributor

You may want to compare against #2218
P.S.: when did you become part of the VSCode gang? 🤩

Here I was all proud of using VSCode and then it's a duplicate PR - sorry @echedey-ls. I think we should merge either one of the two (they're identical now). I don't want to see warnings and the old actions are security supported any longer and we should take security seriously.

Nah man it's all good! Bonus points if you used a regex (PCRE2 flavour if you are into that kinks, it's the famous ripgrep I talk about everywhere).

Continue with this one; in fact, I did not see any warnings when I published those changes, it was for the sake of easing long-term maintenance, so I closed it when they weren't necessary.

@AdamRJensen
Copy link
Member Author

@echedey-ls Want to leave a review?

Copy link
Contributor

@echedey-ls echedey-ls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the following change:

@kandersolar kandersolar added this to the v0.11.1 milestone Sep 26, 2024
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AdamRJensen and @echedey-ls :)

@kandersolar kandersolar merged commit f4fa92e into pvlib:main Sep 26, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants