-
Notifications
You must be signed in to change notification settings - Fork 997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GH action versions #2223
Update GH action versions #2223
Conversation
You may want to compare against #2218 P.S.: when did you become part of the VSCode gang? 🤩 |
Here I was all proud of using VSCode and then it's a duplicate PR - sorry @echedey-ls. I think we should merge either one of the two (they're identical now). I don't want to see warnings and the old actions are security supported any longer and we should take security seriously. |
Nah man it's all good! Bonus points if you used a regex (PCRE2 flavour if you are into that kinks, it's the famous Continue with this one; in fact, I did not see any warnings when I published those changes, it was for the sake of easing long-term maintenance, so I closed it when they weren't necessary. |
@echedey-ls Want to leave a review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with the following change:
- this one (that I missed in my PR) can be updated to
v5
.
https://github.com/AdamRJensen/pvlib-python/blob/1192df32c56061b262cbae8640060d76fbdfc330/.github/workflows/publish.yml#L23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @AdamRJensen and @echedey-ls :)
Duplicate of #2218
remote-data
) and Milestone are assigned to the Pull Request and linked Issue.The current versions of the tools used in the GH actions are outdated and are emitting warnings:
Used the replace-all function in Visual Studio Code that handles all files in a repository link