Miscellaneous improvements to spectrl2 docstring
#2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Cliff Hansen <5393711+cwhanse@users.noreply.github.com>
kandersolar
reviewed
Aug 16, 2024
Co-Authored-By: Kevin Anderson <57452607+kandersolar@users.noreply.github.com>
proposal for a few minor changes
cwhanse
reviewed
Aug 16, 2024
+1 74da756 implements @kandersolar's variable naming suggestion 7bde9fe just proposes a few additional minor docstring changes. Happy to retract this commit if anyone disagrees |
|
This is good to go in my view. Any further thoughts? |
cwhanse
approved these changes
Aug 29, 2024
AdamRJensen
approved these changes
Aug 29, 2024
echedey-ls
approved these changes
Aug 30, 2024
Co-Authored-By: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
kandersolar
changed the title
spectrl2 docstring
|
Thanks @RDaxini! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remote-data) and Milestone are assigned to the Pull Request and linked Issue.Avoids datatype conflict between variable
spectraas an input andspectraas an output#2150 and comment