fit_pvefficiency_adr compatibility with scipy 1.11.2
#1866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you didn't submit this, I would have :) |
AdamRJensen
approved these changes
Sep 21, 2023
|
I'm going to merge this now in the interest of not holding up releasing v0.10.2. Can always follow up later if we have overlooked some subtlety here. |
|
Looks fine to me. Perhaps I would have chosen 0.1, but it doesn't matter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] Closes #xxxx[ ] Tests added[ ] Updates entries indocs/sphinx/source/referencefor API changes.[ ] Adds description and name entries in the appropriate "what's new" file indocs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data) and Milestone are assigned to the Pull Request and linked Issue.I am tired of waiting for the next scipy release to come out (with a fix for scipy/scipy#19103) and resolve our failing CI tests, so here is a fix on our end instead. I guess it is best to include a fix in pvlib anyway.
The problem is that the starting point for a call to
curve_fitwas on the boundary of the acceptable region, so I moved the initial point just inside the bounded region.@adriesse could you please take a look and confirm the new starting point is appropriate?