Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update isotropic transposition references #1864

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Update isotropic transposition references #1864

merged 1 commit into from
Sep 20, 2023

Conversation

AdamRJensen
Copy link
Member

@AdamRJensen AdamRJensen commented Sep 18, 2023

  • I am familiar with the contributing guidelines
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

The reference in the isotropic transposition model seem not to be the original derivation of the model. Instead, I suggest referencing this very thorough paper for the model development. The paper states:

Hottel (e.g., Hottel, 1940, 1941, 1951; Hottel and Woertz, 1942) had such a profound impact in the field of solar energy that some authors (e.g., Loutzenhiser et al., 2007) incorrectly cited Hottel and Woertz (1942) as the originators of the ISM [isotropic sky model]

@kandersolar kandersolar added this to the v0.10.2 milestone Sep 19, 2023
@kandersolar kandersolar merged commit 7608eda into main Sep 20, 2023
19 of 26 checks passed
@kandersolar kandersolar deleted the isotropic_docs branch September 20, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants