Remove deprecated basic_chain method #1862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yes, regardless of how long it's been since the deprecation was put in place, I think we should not remove functionality in minor releases. |
kandersolar
approved these changes
May 24, 2024
wholmgren
approved these changes
May 24, 2024
There was a problem hiding this comment.
Thanks for cleaning up this early experiment @AdamRJensen.
As an aside, here's a link to another, not quite as early experiment using dask and basic chain: wholmgren/pvlib-python mcdask. As we remove this code, just wanting to document that there is unexplored potential using model chain functions instead of the bloated classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] Closes #xxxxdocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).[ ] New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.remote-data) and Milestone are assigned to the Pull Request and linked Issue.I stumbled upon the
basic_chainmethod, which has been deprecated since 0.9.1, hence it seemed time to do a cleanup and remove it entirely.Perhaps it is preferred to wait until a major release?