Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow asymmetrical rotation limits in pvlib.tracking.singleaxis (v2) #1852

Merged
merged 14 commits into from
Sep 13, 2023

Conversation

kandersolar
Copy link
Member

  • Closes Add min_angle argument to tracking.singleaxis #1777
  • I am familiar with the contributing guidelines
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

#1809 needed a few changes before merging but the PR did not allow maintainer edits, so here is a second PR that preserves the original commits.

@kandersolar kandersolar added this to the v0.10.2 milestone Sep 12, 2023
Copy link
Member

@AdamRJensen AdamRJensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

docs/sphinx/source/whatsnew/v0.10.2.rst Outdated Show resolved Hide resolved
@kandersolar kandersolar merged commit 4237a67 into pvlib:main Sep 13, 2023
24 of 30 checks passed
@kandersolar kandersolar deleted the sat_asymmetrical_limits branch September 13, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add min_angle argument to tracking.singleaxis
3 participants