Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect description of surface_azimuth parameter in get_pvgis_hourly #1838

Merged

Conversation

tongpu
Copy link
Contributor

@tongpu tongpu commented Aug 22, 2023

Fixes a documentation issue introduced with the change to align surface_azimuth in pvgis_get_hourly, where the implementation is clockwise from north, but the documentation strings mention counter-clockwise from north.

@kandersolar kandersolar added this to the v0.10.2 milestone Aug 22, 2023
@kandersolar
Copy link
Member

Thanks for catching and fixing this error @tongpu! Can you list yourself as a contributor and make a note about this doc correction in the 0.10.2 whatsnew file? https://github.com/pvlib/pvlib-python/blob/main/docs/sphinx/source/whatsnew/v0.10.2.rst

@tongpu
Copy link
Contributor Author

tongpu commented Aug 22, 2023

I've added an update to the docs section.

Copy link
Member

@cwhanse cwhanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tongpu

docs/sphinx/source/whatsnew/v0.10.2.rst Outdated Show resolved Hide resolved
Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tongpu

@kandersolar kandersolar changed the title Fix misleading documentation for surface_azimuth Fix incorrect description of surface_azimuth parameter in get_pvgis_hourly Aug 22, 2023
@kandersolar kandersolar merged commit 3e16ba9 into pvlib:main Aug 22, 2023
@tongpu tongpu deleted the docs/fix_pvgis_surface_azimuth_documentation branch August 22, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pvlib.iotools.get_pvgis_hourly's surface_azimuth parameter doesn't use pvlib's azimuth convention
3 participants