Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pvsystem.singlediode with method='newton' can be passed pd.Series of length one. #1822

Merged
merged 11 commits into from
Sep 12, 2023

Conversation

reepoi
Copy link
Contributor

@reepoi reepoi commented Aug 1, 2023

  • Closes singlediode: newton solver fails with Series input of length one #1787
  • I am familiar with the contributing guidelines
  • Tests added
  • [ ] Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

The cause of the issue is that pandas.Series of length one cannot be converted to bool values. When pandas.Series of length one are passed to bishop88, the newton solver attempts that conversion here.

Also, reimplemented singlediode._get_size_and_shape and named it singlediode._shape_of_max_size. singlediode._prepare_newton_inputs, pvsystem.i_from_v, and pvsystem.v_from_i used singlediode._get_size_and_shape, so they have been updated too. pvsystem.i_from_v, and pvsystem.v_from_i logic for choosing the correct output shape is now similar to the logic in singlediode._lambertw_i_from_v.

@cwhanse cwhanse added this to the v0.10.2 milestone Aug 10, 2023
Copy link
Member

@cwhanse cwhanse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @reepoi much easier to follow with these changes.

Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice associated cleanup indeed. Thanks @reepoi

@kandersolar kandersolar merged commit 27a3a07 into pvlib:main Sep 12, 2023
18 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

singlediode: newton solver fails with Series input of length one
3 participants