Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PDK ignoring config_defaults.yml delete values #924

Open
alexjfisher opened this issue Nov 20, 2020 · 4 comments
Open

PDK ignoring config_defaults.yml delete values #924

alexjfisher opened this issue Nov 20, 2020 · 4 comments
Labels
bug needs-triage Newly created issue that has not been reviewed by a PDK contributor no-issue-activity pdk-update Related to the pdk update command

Comments

@alexjfisher
Copy link

Describe the bug
When using a forked pdk template, if I want to delete an arbitrary file, I should be able to via config_defaults.yml

To Reproduce
Add the following to config_defaults.yml

Jenkinsfile:
  delete: true

Expected behavior
When running PDK update on a module using this template, I'd expect any existing Jenkinsfile to be deleted.

Additional context
PDK 1.18.1 on CentOS7 via RPM

This issue is similar to #444
I can workaround the bug, by adding an empty file to moduleroot. IMO. this shouldn't be required.

@alexjfisher alexjfisher added bug needs-triage Newly created issue that has not been reviewed by a PDK contributor labels Nov 20, 2020
@jpogran jpogran added the pdk-update Related to the pdk update command label Feb 26, 2021
@github-actions
Copy link

This issue has been marked stale because it is open with no recent activity. The PDK Team is actively prioritizing existing bugs and new features, if this issue is still important to you please comment and we will add this to our backlog to complete.

@ardrigh
Copy link
Contributor

ardrigh commented Nov 29, 2021

This issue is similar to #444 I can workaround the bug, by adding an empty file to moduleroot. IMO. this shouldn't be required.

Workaround required based on the current design which looks at files in the templates directory to then process which ones are unmanaged or deleted.

files_in_template(dirs).each do |template_file, template_loc|

I guess the alternative would be parsing config_defaults.yml and .sync.yml (which are meant to merge into a combined set) for header entries. But that approach seems more prone to errors IMO.

@github-actions
Copy link

This issue has been marked stale because it is open with no recent activity. The PDK Team is actively prioritizing existing bugs and new features, if this issue is still important to you please comment and we will add this to our backlog to complete.

@cruelsmith
Copy link

With the silent drop (without notice in release notes / changelog) of multiple features with puppetlabs/pdk-templates#510 it is more important than ever when maintaining many projects.
All pdk projects that update to pdk 3 will still contain these old feature files that are not maintained anymore. Note that even multiple puppetlabs modules still contain them and they needs manual cleanup without this requested feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug needs-triage Newly created issue that has not been reviewed by a PDK contributor no-issue-activity pdk-update Related to the pdk update command
Projects
None yet
Development

No branches or pull requests

4 participants