-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
temporary high quality images #652
Comments
I'm a bit confused. This is more or less exactly what is done right now (see). When the user zooms into the image, the image is converted to JPEG server-side and displayed to the user.
For now, you'll need to compile |
memories/lib/Controller/ImageController.php Line 364 in bf7721c
Yes I totally missed it and didn't look into the function, I thought it just called the original image. So then I could just change that to WebP, cool. Then my functional idea would actually be to add more formats such as quality, maxWidth, maxHeight settings. And an option is to be added so that it always converts to the format you want.
Warning this is untested sample code, it's just meant to explain an idea better.
Thanks will try. |
Moved to #653 (comment) |
https://github.com/pulsejet/memories/tree/master/src/native.ts#L16
https://github.com/pulsejet/memories/tree/master/src/components/viewer/Viewer.vue#L808
I have a feature idea for the app:
IMAGE_HQ_PREVIEW
This is an image that is generated with 100% quality and max resolution. It may put some load on the CPU but can save bandwidth and achieve the same results as loading the full image. JPEG could be used, which can be processed quickly, or bandwidth-saving WebP, which also offers fast processing. The generation could be integrated here or a separate file could be created like /lib/Controller/Previewer.php. Then, in /src/components/viewer/Viewer.vue, you can simply request the IMAGE_HQ_PREVIEW when, for example, zooming is performed. One could go further and create a cache with a maximum size and file count.
What would you think of the idea?
I have a question, how do you change the FFmpeg quality setting from "Faster" to "Ultrafast"?
https://github.com/pulsejet/memories/blob/master/docs/system-config.md
https://github.com/pulsejet/memories/blob/master/docs/hw-transcoding.md
Oh, and I think the app is fantastic. I had a similar idea recently, and then someone recommended your app to me. It's already working very well, there was only one installation error, which could be easily fixed.
The text was updated successfully, but these errors were encountered: