Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for place list with reverse geocoding #395

Merged
merged 32 commits into from
Feb 7, 2023
Merged

Support for place list with reverse geocoding #395

merged 32 commits into from
Feb 7, 2023

Conversation

pulsejet
Copy link
Owner

@pulsejet pulsejet commented Feb 6, 2023

This will likely conflict/merge with #376

image

@pulsejet pulsejet added the feature New feature or request label Feb 6, 2023
@pulsejet pulsejet added this to the 4.11 milestone Feb 6, 2023
@RaymondHuang210129
Copy link
Contributor

I believe this approach is better than #376 . Thanks for having this feature available.

@pulsejet
Copy link
Owner Author

pulsejet commented Feb 6, 2023

I believe this approach is better than #376 . Thanks for having this feature available.

They're somewhat orthogonal (at least the implementation). We still need the map regardless.

@RaymondHuang210129
Copy link
Contributor

The places-setup command seems to break the PHP memory limit during the execution.
My testing environment has PHP version 8.1.14 and a memory limit of 512MB.

Inserted 25000 places, 320.5/s, ETA: 1904s, Last: Osborne
Inserted 25500 places, 322.8/s, ETA: 1889s, Last: Stanford
PHP Fatal error:  Allowed memory size of 536870912 bytes exhausted (tried to allocate 20480 bytes) in /var/www/html/lib/private/DB/BacktraceDebugStack.php on line 31

@pulsejet
Copy link
Owner Author

pulsejet commented Feb 6, 2023

Try 2GB

PHP_MEMORY_LIMIT=2G php occ memories:places-setup

@pulsejet pulsejet merged commit e19302c into master Feb 7, 2023
@pulsejet pulsejet deleted the places branch February 7, 2023 18:34
@thrillfall
Copy link

i am just running the index and can already see my holiday locations in the tiles and i just wanted to say: THANK YOU!!! This is so awesome!! 💟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants