Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rules_protobuf to rules_go 0.16.0 #248

Closed
katre opened this issue Oct 18, 2018 · 7 comments
Closed

Update rules_protobuf to rules_go 0.16.0 #248

katre opened this issue Oct 18, 2018 · 7 comments

Comments

@katre
Copy link

katre commented Oct 18, 2018

This will involve removing the use of go_prefix in the rules.

See release notes for rules_go: https://github.com/bazelbuild/rules_go/releases/tag/0.16.0
Note on the deprecation and removal of go_prefix: bazelbuild/rules_go#721

Note that rules_protobuf not updating holds back any project that depends on rules_protobuf.

@pcj
Copy link
Contributor

pcj commented Oct 18, 2018

Hi @katre I've pretty much totally rewritten these rules to layer on top of native.proto_library rule, now under a new organization. Still working on the documentation but they use a recent version of rules_go. There are a few features not included there but overall the rules are much simpler. I'd consider migrating to them. Hope that's not too disruptive.

https://github.com/stackb/rules_proto

@katre
Copy link
Author

katre commented Oct 18, 2018

Hmm, this isn't actually my project I'm migrating, but I'll give it a shot, thanks.

@hlopko
Copy link

hlopko commented Oct 19, 2018

Hi Paul,
does it mean that these rules_protobuf are deprecated/unmaintained?

@katre
Copy link
Author

katre commented Oct 19, 2018

@pcj I took a look at stackb/rules_proto, and I can't even build that (looks like there's a local_repository in the WORKSPACE for your own copy of rules_dotnet, and I can't figure out a online version to use).

@hlopko
Copy link

hlopko commented Oct 23, 2018

Can we get this PR merged here then?

@pcj
Copy link
Contributor

pcj commented Oct 23, 2018

This is an issue, not a PR. I'll create a PR on rules_k8s to update the protobuf rules.

@katre
Copy link
Author

katre commented Oct 23, 2018

Thanks!

@katre katre closed this as completed Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants