-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added some mpg123 wrapped functions #762
Conversation
Force-pushed, I forgot to commit those generated files. |
wrapperhelper is not working 100% correct. There are many cases were it generate function signature with a 'E' for no real reason. So use it carrefully. |
Because of the state of the wrapperhelper, I prefer not to document it for now. It's not in a good enough state. |
Or at least add a lot of warning as it's not really working and should not be use to directly generated box files. |
Yeah, I've double-checked all the committed ones.
It's useful as a reference, should I revert the README changes or add some warnings at the top? |
At least add some warning yes. I don't want to get PR with destroyed wrapping... |
Done. |
On the subject of Wrapping. Not sure if you noticed but I introduced a |
Oh, I didn't notice this one, sounds like a lot of work TBD. I'll check it out later and get involved for sure. |
I just took a look at the |
Yes, in all wrappedXXXX.c files. I started, but just did like... 10% or 20%, no more than that. |
I think I can convert them all today. |
All? Well, that's a lot of work. Some files, like pulse or x11, have a lot of them! |
About 600, I think it's doable ;) |
:O well, good luck! |
Added for this game: https://cyfo.itch.io/katkoot, only
mpg123_info
is needed, by I added others anyway.I used wrapperhelper, with this command under x86-64:
./helper /usr/include/mpg123.h libmpg123 x64 x64 --
It throws me a bunch of errors, and some mpg123 function wrappers are missing, don't know what's wrong.