-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing wrappings for winewayland.so #1599
Conversation
For bool, I would use For the SIGILL, it might be something else. Check if you have some |
Also, I checked the added function, and they are ok (appart from the bool-> |
Alriight, thanks for checking it! I'm changing the bool to Also I found exactly that error message. I just had to set a GDB breakpoint on that line since I still can't get the log messages printed on my terminal. Now I'm trying to add the missing |
Listenner are more tricky to implement. if you don't have enough example, tell me, and I'll add it. |
These were missing on wine-9.9 built with `--enable-win64` and `--with-wayland=yes` on Ubuntu 24.04 "noble". Does not work at this point! Now there is a SIGILL during/after mapping winewayland.so due to a missing zxdg_output_v1 listener.
That would be great I think. This was my attempt and I don't see any obvious problems without a bit more understanding about the mechanisms. |
According to https://searchfox.org/mozilla-central/source/widget/gtk/wayland/xdg-output-unstable-v1-client-protocol.h#191 you are missing "done", vFpp, between "logical_size" and "name" |
Haha yes, this was it. I had seen it here, read something about "deprecated", did not see it in the winewayland.so symbols and decided to omit it. Of course this is not how box64 works, and this Wayland listener interface.. The result is that I can now start |
This is used by wine's waylandclient.so. Tested with wine-9.9 regedit and winecfg.
thanks, and good work wrapping the listener ;) |
only possible with your quick feedback! thanks, this was fun |
* Add missing wrappings for winewayland.so These were missing on wine-9.9 built with `--enable-win64` and `--with-wayland=yes` on Ubuntu 24.04 "noble". Does not work at this point! Now there is a SIGILL during/after mapping winewayland.so due to a missing zxdg_output_v1 listener. * wrappedwaylandclient: add zxdg_output_v1 listener This is used by wine's waylandclient.so. Tested with wine-9.9 regedit and winecfg.
This was a late-night attempt to fix issue #1581.
I still don't really know how the wrappings work (I should take time and learn) so I just did what seemed right. For
size_t
andbool
I guessed how they are specified ('L' and 'c'??).Unsuprisingly, it does not work at this point! Now there is a SIGILL during/after mapping winewayland.so.