Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update method of asking XArray not to write _FillValue #8

Merged
merged 1 commit into from
Apr 8, 2019

Conversation

DWesl
Copy link
Collaborator

@DWesl DWesl commented Mar 30, 2019

Description

_FillValue = None is now the preferred way to ask XArray not to write fill values

Motivation and Context

This allows the examples to work with default versions of XArray.
Apparently this changed in the few years since I looked at the documentation: see pydata/xarray#1598 for discussion.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I give permission for my code to be distributed under the existing license

@DWesl DWesl self-assigned this Mar 31, 2019
@DWesl DWesl added the bug Something isn't working label Mar 31, 2019
@DWesl DWesl merged commit 83545cd into psu-inversion:master Apr 8, 2019
@DWesl DWesl deleted the xarray_no_fillvalue_is_none branch April 8, 2019 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant