Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In current version HA couldn't connect to roomba. #223

Closed
SnegniyBars opened this issue Feb 11, 2024 · 2 comments · Fixed by #228
Closed

In current version HA couldn't connect to roomba. #223

SnegniyBars opened this issue Feb 11, 2024 · 2 comments · Fixed by #228

Comments

@SnegniyBars
Copy link

In logs i get error:

 File "/usr/local/lib/python3.12/site-packages/roombapy/getpassword.py", line 81, in _get_socket
    ssl_socket = ssl.wrap_socket(
                 ^^^^^^^^^^^^^^^
AttributeError: module 'ssl' has no attribute 'wrap_socket'

Description:
From What's new:
Remove the ssl.wrap_socket() function, deprecated in Python 3.7: instead, create a ssl.SSLContext object and call its ssl.SSLContext.wrap_socket method. Any package that still uses ssl.wrap_socket() is broken and insecure. The function neither sends a SNI TLS extension nor validates server hostname. Code is subject to CWE-295: Improper Certificate Validation. (Contributed by Victor Stinner in python/cpython#94199.)

@DennisMelamed
Copy link

To add some additional data, the below link includes a best-guess fix (appears to be untested):
home-assistant/core#109772 (comment)

@IGNWoudenberg
Copy link

I’m getting more or less the same as a new Roomba J7 owner and on the latest version:

Home Assistant Core
File "/usr/src/homeassistant/homeassistant/components/roomba/config_flow.py", line 230, in async_step_link
roomba_pw = RoombaPassword(self.host)
File "/usr/local/lib/python3.12/site-packages/roombapy/getpassword.py", line 21, in init
File "/usr/local/lib/python3.12/site-packages/roombapy/getpassword.py", line 81, in _get_socket
File "/usr/src/homeassistant/homeassistant/components/roomba/config_flow.py", line 230, in async_step_link
roomba_pw = RoombaPassword(self.host)

Core
2024.2.1
Supervisor
2024.01.1
Operating System
11.5
Frontend
20240207.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants