Return 503 on healthz with error #6754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvanloon
added
Bug
farazdagi
previously approved these changes
Jul 28, 2020
prestonvanloon
added
OK to merge
Ready For Review
farazdagi
suggested changes
Jul 28, 2020
Co-authored-by: Victor Farazdagi <simple.square@gmail.com>
farazdagi
approved these changes
Jul 29, 2020
Codecov Report
@@ Coverage Diff @@
## master #6754 +/- ##
==========================================
- Coverage 62.63% 62.29% -0.34%
==========================================
Files 385 384 -1
Lines 30099 29787 -312
==========================================
- Hits 18852 18557 -295
+ Misses 8578 8574 -4
+ Partials 2669 2656 -13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
The healthz must return an error HTTP status code.
Which issues(s) does this PR fix?
Fixes a regression from #5558
Other notes for review
For this, I have chosen 503 since that indicates that the server is not ready to serve requests.