Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use alpine base image including libstdc++ #5777

Merged
merged 2 commits into from
May 7, 2020

Conversation

prestonvanloon
Copy link
Member

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

Apline images did not work previously.

Which issues(s) does this PR fix?

Fixes #5768

Other notes for review

@prestonvanloon prestonvanloon requested a review from a team as a code owner May 7, 2020 18:34
@prestonvanloon prestonvanloon added the Ready For Review A pull request ready for code review label May 7, 2020
@codecov
Copy link

codecov bot commented May 7, 2020

Codecov Report

Merging #5777 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5777   +/-   ##
=======================================
  Coverage   54.45%   54.45%           
=======================================
  Files         310      310           
  Lines       26017    26017           
=======================================
  Hits        14167    14167           
  Misses       9783     9783           
  Partials     2067     2067           

@prylabs-bulldozer prylabs-bulldozer bot merged commit 63e2e8a into master May 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-docker-alpine branch May 7, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alpine images are not yet functional
2 participants