Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init-sync discard debug logs in tests #5774

Merged
merged 6 commits into from
May 7, 2020
Merged

Init-sync discard debug logs in tests #5774

merged 6 commits into from
May 7, 2020

Conversation

farazdagi
Copy link
Contributor

What type of PR is this?
Other

What does this PR do? Why is it needed?

  • Moves setup functions into a common place (currently they are scattered across fetcher, queue, round robin)
  • redirect log output into discard (as we have with other tests). When coding, one can comment out and see the debug logs)

@farazdagi farazdagi added Ready For Review A pull request ready for code review OK to merge labels May 7, 2020
@farazdagi farazdagi requested a review from nisdas May 7, 2020 13:02
@farazdagi farazdagi requested a review from a team as a code owner May 7, 2020 13:02
@farazdagi farazdagi self-assigned this May 7, 2020
@farazdagi farazdagi requested review from shayzluf and 0xKiwi May 7, 2020 13:02
@prylabs-bulldozer prylabs-bulldozer bot merged commit 40c2974 into master May 7, 2020
@delete-merged-branch delete-merged-branch bot deleted the init-sync-discard-debug-logs branch May 7, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nisdas nisdas nisdas approved these changes

@shayzluf shayzluf Awaiting requested review from shayzluf

@0xKiwi 0xKiwi Awaiting requested review from 0xKiwi

Assignees

@farazdagi farazdagi

Labels
Ready For Review A pull request ready for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@farazdagi @nisdas