Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsSlashableBlock rpc endpoint implementation #5765

Merged
merged 17 commits into from
May 8, 2020
Merged

Conversation

shayzluf
Copy link
Contributor

@shayzluf shayzluf commented May 6, 2020

What type of PR is this?
Feature

What does this PR do? Why is it needed?
In order to enable validator protection slasher needs an endpoint that registered users can use to make sure that the validator is not going to be slashed by submitting their duties.

Which issues(s) does this PR fix?

Fixes #5189

@shayzluf shayzluf requested a review from a team as a code owner May 6, 2020 13:11
@shayzluf shayzluf self-assigned this May 6, 2020
@shayzluf shayzluf added the Ready For Review A pull request ready for code review label May 6, 2020
@shayzluf shayzluf mentioned this pull request May 6, 2020
7 tasks
@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #5765 into master will decrease coverage by 0.24%.
The diff coverage is 41.42%.

@@            Coverage Diff             @@
##           master    #5765      +/-   ##
==========================================
- Coverage   57.68%   57.43%   -0.25%     
==========================================
  Files         312      312              
  Lines       26165    26035     -130     
==========================================
- Hits        15094    14954     -140     
+ Misses       8995     8982      -13     
- Partials     2076     2099      +23     

slasher/rpc/server.go Show resolved Hide resolved
slasher/rpc/server.go Show resolved Hide resolved
slasher/rpc/server.go Show resolved Hide resolved
rauljordan
rauljordan previously approved these changes May 8, 2020
…able_block

# Conflicts:
#	beacon-chain/core/blocks/block_operations.go
@shayzluf shayzluf merged commit c1a8b41 into master May 8, 2020
@delete-merged-branch delete-merged-branch bot deleted the is_slashable_block branch May 8, 2020 05:52
@0xKiwi 0xKiwi changed the title Is slashable block rpc endpoint implementation IsSlashableBlock rpc endpoint implementation May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reintroduce slasher RPC server
2 participants