Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future slot check for state end point #5755

Merged
merged 6 commits into from
May 6, 2020
Merged

Future slot check for state end point #5755

merged 6 commits into from
May 6, 2020

Conversation

terencechain
Copy link
Member

This fixes #5753

Returns proper error if user requests future slot

@terencechain terencechain added Bug Something isn't working Ready For Review A pull request ready for code review labels May 5, 2020
@terencechain terencechain requested a review from a team as a code owner May 5, 2020 23:36
@terencechain terencechain self-assigned this May 5, 2020
@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #5755 into master will decrease coverage by 4.78%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5755      +/-   ##
==========================================
- Coverage   25.30%   20.51%   -4.79%     
==========================================
  Files         219      239      +20     
  Lines       18579    21138    +2559     
==========================================
- Hits         4701     4337     -364     
- Misses      13132    16079    +2947     
+ Partials      746      722      -24     

@terencechain terencechain merged commit aea7a8d into master May 6, 2020
@delete-merged-branch delete-merged-branch bot deleted the 5753 branch May 6, 2020 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Endpoint /eth/v1alpha1/beacon/state does not address future slot request
2 participants