Move "Enter a password" cmd instructions to shared/cmd

shared/cmd/BUILD.bazel

@@ -15,6 +15,7 @@ go_library(
         "@com_github_sirupsen_logrus//:go_default_library",
         "@in_gopkg_urfave_cli_v2//:go_default_library",
         "@in_gopkg_urfave_cli_v2//altsrc:go_default_library",
+        "@org_golang_x_crypto//ssh/terminal:go_default_library",
     ],
 )
 

shared/cmd/helpers.go

@@ -7,6 +7,7 @@ import (
 	"strings"
 
 	"github.com/sirupsen/logrus"
+	"golang.org/x/crypto/ssh/terminal"
 )
 
 var log = logrus.WithField("prefix", "node")
@@ -42,3 +43,18 @@ func ConfirmAction(actionText string, deniedText string) (bool, error) {
 
 	return confirmed, nil
 }
+
+// EnterPassword queries the user for their password through the terminal, in order to make sure it is
+// not passed in a visible way to the terminal.
+func EnterPassword() (string, error) {
+	var passphrase string
+	log.Info("Enter a password:")
+	bytePassword, err := terminal.ReadPassword(int(os.Stdin.Fd()))
+	if err != nil {
+		log.Fatalf("Could not read account password: %v", err)
+		return passphrase, err
+	}
+	text := string(bytePassword)
+	passphrase = strings.Replace(text, "\n", "", -1)
+	return passphrase, nil
+}

validator/accounts/BUILD.bazel

@@ -10,11 +10,11 @@ go_library(
     ],
     deps = [
         "//contracts/deposit-contract:go_default_library",
+        "//shared/cmd:go_default_library",
         "//shared/keystore:go_default_library",
         "//shared/params:go_default_library",
         "@com_github_pkg_errors//:go_default_library",
         "@com_github_sirupsen_logrus//:go_default_library",
-        "@org_golang_x_crypto//ssh/terminal:go_default_library",
     ],
 )
 

validator/accounts/account.go

@@ -14,10 +14,10 @@ import (
 
 	"github.com/pkg/errors"
 	contract "github.com/prysmaticlabs/prysm/contracts/deposit-contract"
+	"github.com/prysmaticlabs/prysm/shared/cmd"
 	"github.com/prysmaticlabs/prysm/shared/keystore"
 	"github.com/prysmaticlabs/prysm/shared/params"
 	"github.com/sirupsen/logrus"
-	"golang.org/x/crypto/ssh/terminal"
 )
 
 var log = logrus.WithField("prefix", "accounts")
@@ -136,16 +136,13 @@ func Exists(keystorePath string) (bool, error) {
 // CreateValidatorAccount creates a validator account from the given cli context.
 func CreateValidatorAccount(path string, passphrase string) (string, string, error) {
 	if passphrase == "" {
-		log.Info("Create a new validator account for eth2")
-		log.Info("Enter a password:")
-		bytePassword, err := terminal.ReadPassword(int(os.Stdin.Fd()))
+		log.Info("Creating a new validator account for eth2")
+		enteredPassphrase, err := cmd.EnterPassword()
 		if err != nil {
-			log.Fatalf("Could not read account password: %v", err)
-			return path, passphrase, err
+			log.Fatal(err)
+			return path, enteredPassphrase, err
 		}
-		text := string(bytePassword)
-		passphrase = strings.Replace(text, "\n", "", -1)
-
+		passphrase = enteredPassphrase
 	}
 
 	if path == "" {