Load chain config from file #5694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
reviewed
Apr 30, 2020
farazdagi
previously requested changes
Apr 30, 2020
2 tasks
Co-authored-by: Victor Farazdagi <simple.square@gmail.com>
Co-authored-by: Victor Farazdagi <simple.square@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #5694 +/- ##
===========================================
+ Coverage 22.26% 54.94% +32.67%
===========================================
Files 180 313 +133
Lines 15790 26098 +10308
===========================================
+ Hits 3516 14339 +10823
+ Misses 11723 9686 -2037
- Partials 551 2073 +1522 |
farazdagi
reviewed
Apr 30, 2020
…in_config # Conflicts: # shared/testutil/spectest.go
nisdas
reviewed
May 5, 2020
nisdas
reviewed
May 5, 2020
rauljordan
reviewed
May 5, 2020
rauljordan
reviewed
May 5, 2020
nisdas
reviewed
May 5, 2020
…to yaml_chain_config
terencechain
requested changes
May 5, 2020
…to yaml_chain_config # Conflicts: # beacon-chain/node/node.go
terencechain
approved these changes
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature
What does this PR do? Why is it needed?
load chain config from yaml file
Which issues(s) does this PR fix?
Part of #5693