Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable skipped block list paging unit test #5691

Merged
merged 10 commits into from
May 2, 2020

Conversation

farazdagi
Copy link
Contributor

@farazdagi farazdagi commented Apr 30, 2020

What type of PR is this?

Other

What does this PR do? Why is it needed?

Other notes for review

  • the issue was rooted in inaccurate state modification in tests, this has been fixed
  • params.OverrideBeaconConfigWithReset() has been added and proposed usage inside tests:
resetCfg := params.OverrideBeaconConfigWithReset(params.MainnetConfig())
defer resetCfg()
  • this usage makes sure that individual test functions are idempotent
  • test setup code has been moved from init() (in one of the tests files) to beacon_test.go:TestMain() (where it is easier to find setup/teardown code for the package).

Note: I will now review all the other code using inaccurate state amendment and file fixing PR (if any) seprately.

@farazdagi farazdagi self-assigned this Apr 30, 2020
@farazdagi farazdagi added the Ready For Review A pull request ready for code review label May 1, 2020
@farazdagi farazdagi marked this pull request as ready for review May 1, 2020 21:52
@farazdagi farazdagi requested a review from a team as a code owner May 1, 2020 21:52
@prylabs-bulldozer prylabs-bulldozer bot merged commit af5b922 into master May 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the unskip-block-list-test branch May 2, 2020 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants