Implement GetBeaconState Endpoint #5668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A quick note on this, a prysm node by default does not keep beacon state from genesis slot to last finalized slot. If user wants to query historical state older than last finalized slot, please use flag |
|
Cool I'll add a note about that |
prestonvanloon
requested changes
Apr 28, 2020
beacon-chain/rpc/beacon/state.go
Outdated
| pbp2p "github.com/prysmaticlabs/prysm/proto/beacon/p2p/v1" | ||
| pbrpc "github.com/prysmaticlabs/prysm/proto/beacon/rpc/v1" | ||
| //"google.golang.org/grpc/codes" | ||
| //"google.golang.org/grpc/status" |
There was a problem hiding this comment.
Unimplemented, still in progress
beacon-chain/rpc/beacon/state.go
Outdated
| req *pbrpc.BeaconStateRequest, | ||
| ) (*pbp2p.BeaconState, error) { | ||
|
|
||
| //currentSlot := bs.GenesisTimeFetcher.CurrentSlot() |
rauljordan
commented
Apr 28, 2020
Codecov Report
@@ Coverage Diff @@
## master #5668 +/- ##
===========================================
+ Coverage 26.44% 41.86% +15.42%
===========================================
Files 239 272 +33
Lines 20892 23273 +2381
===========================================
+ Hits 5524 9744 +4220
+ Misses 14293 11762 -2531
- Partials 1075 1767 +692 |
shared/featureconfig/flags.go
Outdated
| @@ -150,6 +150,10 @@ var ( | |||
| Name: "wait-for-synced", | |||
| Usage: "Uses WaitForSynced for validator startup, to ensure a validator is able to communicate with the beacon node as quick as possible", | |||
| } | |||
| enableDebugRPCEndpoints = &cli.BoolFlag{ | |||
| Name: "enable-debug-rpc-endpoints", | |||
There was a problem hiding this comment.
Is a feature flag appropriate or should you make this a regular flag?
Feature flags are temporary while you work on the feature
prestonvanloon
previously approved these changes
Apr 29, 2020
shayzluf
reviewed
Apr 29, 2020
beacon-chain/node/node.go
Outdated
| @@ -536,6 +536,7 @@ func (b *BeaconNode) registerRPCService() error { | |||
| slasherCert := b.cliCtx.String(flags.SlasherCertFlag.Name) | |||
| slasherProvider := b.cliCtx.String(flags.SlasherProviderFlag.Name) | |||
| mockEth1DataVotes := b.cliCtx.Bool(flags.InteropMockEth1DataVotesFlag.Name) | |||
| enableDebugRPCEndpoints := ctx.Bool(flags.EnableDebugRPCEndpoints.Name) | |||
There was a problem hiding this comment.
something went wrong with the indent here
shayzluf
reviewed
Apr 29, 2020
beacon-chain/node/node.go
Outdated
| @@ -568,6 +569,7 @@ func (b *BeaconNode) registerRPCService() error { | |||
| SlasherCert: slasherCert, | |||
| SlasherProvider: slasherProvider, | |||
| StateGen: b.stateGen, | |||
| EnableDebugRPCEndpoints: enableDebugRPCEndpoints, | |||
shayzluf
reviewed
Apr 29, 2020
beacon-chain/node/node.go
Outdated
| @@ -608,13 +610,15 @@ func (b *BeaconNode) registerGRPCGateway() error { | |||
| selfAddress := fmt.Sprintf("127.0.0.1:%d", b.cliCtx.Int(flags.RPCPort.Name)) | |||
| gatewayAddress := fmt.Sprintf("0.0.0.0:%d", gatewayPort) | |||
| allowedOrigins := strings.Split(b.cliCtx.String(flags.GPRCGatewayCorsDomain.Name), ",") | |||
| enableDebugRPCEndpoints := b.cliCtx.Bool(flags.EnableDebugRPCEndpoints.Name) | |||
prestonvanloon
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
Follow-up on #5666, this PR implements the
GetBeaconState/v1/beacon/stateendpoint into Prysm gated behind the feature flag--enable-debug-rpc, useful for interop testing.CC @protolambda