fixes bug with binary verification #5627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farazdagi
added
Ready For Review
…abs/prysm into fix-prysm-sh-verification-bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
\, for line delimiters but they obviously got trimmed by IDE (we can instruct Goland not to trim spaces, but that's too of hacky way to do it). So, I've changed things to use heredoc, which doesn't require any particular IDE config.Which issues(s) does this PR fix?
Fixes #5625
Other notes for review
Now, when you run the script with unmet dependency, you'll get:
And binary will refuse to start! You have either to disable verification, or install deps,
When, checksum is wrong:
You can also force skipping checksum checks:
