Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back archival endpoint GetValidatorBalances with fallback #5620

Merged
merged 25 commits into from
Apr 27, 2020

Conversation

terencechain
Copy link
Member

This PR added back archival end point GetValidatorBalances with a proper fallback when --new-state-mgmt is not applied
The PR cherry picked #5458 was already approved and the fallback logic was already used in the wild. There's no new logic and nothing substantive here

@terencechain terencechain added the Ready For Review A pull request ready for code review label Apr 25, 2020
@terencechain terencechain requested a review from a team as a code owner April 25, 2020 17:12
@terencechain terencechain self-assigned this Apr 25, 2020
@codecov
Copy link

codecov bot commented Apr 25, 2020

Codecov Report

Merging #5620 into master will decrease coverage by 5.27%.
The diff coverage is 73.91%.

@@            Coverage Diff             @@
##           master    #5620      +/-   ##
==========================================
- Coverage   26.27%   21.00%   -5.28%     
==========================================
  Files         239      179      -60     
  Lines       20710    16019    -4691     
==========================================
- Hits         5442     3364    -2078     
+ Misses      14196    12105    -2091     
+ Partials     1072      550     -522     

@terencechain terencechain merged commit e3e9863 into master Apr 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the validator-balances-fallback branch April 27, 2020 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants