Add HeadGenesisValidatorRoot for DomainData
#5582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Enhancement
Codecov Report
@@ Coverage Diff @@
## master #5582 +/- ##
=======================================
Coverage 39.41% 39.41%
=======================================
Files 239 239
Lines 20643 20643
=======================================
Hits 8136 8136
Misses 10978 10978
Partials 1529 1529 |
…s/prysm into head-genesis-validator-root
rauljordan
approved these changes
Apr 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5512
It is wasteful to copy the entire state just for genesis validator root.. (1.3GB 😱) 👇
Change list:
HeadGenesisValidatorRoottoHeadFetcherinterfaceHeadGenesisValidatorRootfor RPC callDomainDatainstead of usingHeadState