Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slasher batch db read and a write #5534

Merged
merged 24 commits into from
Apr 21, 2020
Merged

Slasher batch db read and a write #5534

merged 24 commits into from
Apr 21, 2020

Conversation

shayzluf
Copy link
Contributor

[Part of] #5040


Description

batch read and write db functions for long spans

@shayzluf shayzluf requested a review from a team as a code owner April 20, 2020 09:59
@shayzluf shayzluf changed the title Slasher batch db read Slasher batch db read and a write Apr 20, 2020
@codecov
Copy link

codecov bot commented Apr 20, 2020

Codecov Report

Merging #5534 into master will decrease coverage by 4.73%.
The diff coverage is 73.80%.

@@            Coverage Diff             @@
##           master    #5534      +/-   ##
==========================================
- Coverage   20.05%   15.31%   -4.74%     
==========================================
  Files         238      116     -122     
  Lines       20367     8998   -11369     
==========================================
- Hits         4084     1378    -2706     
+ Misses      15615     7452    -8163     
+ Partials      668      168     -500     

@shayzluf shayzluf added the Ready For Review A pull request ready for code review label Apr 20, 2020
@rauljordan
Copy link
Contributor

This also needs to be added to the db interface

@shayzluf
Copy link
Contributor Author

@rauljordan ready again

@rauljordan rauljordan merged commit 8cba109 into master Apr 21, 2020
@rauljordan rauljordan deleted the slasher_batch_db_read branch April 21, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants