Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing CPU Profiling and Tracing #550

Merged
merged 3 commits into from
Sep 21, 2018

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Sep 21, 2018

Resolves #549

  • This was done by adding a context, to debug.Exit() , so that profiling and tracing would only be stopped if the flags had been enabled previously.
  • For resolving the second part of the issue, a check for a canceled context was added so that the beacon service routines in the beacon package would not loop endlessly even though the rpc service had been shut down.
  • Modify tests to maintain 100% test coverage in the beacon package.

@nisdas nisdas added Bug Something isn't working Ready For Review A pull request ready for code review Validator Client labels Sep 21, 2018
@nisdas nisdas added this to the Ruby milestone Sep 21, 2018
@nisdas nisdas self-assigned this Sep 21, 2018
@nisdas nisdas changed the title Fixing profiling and tracing Fixing CPU Profiling and Tracing Sep 21, 2018
@codecov
Copy link

codecov bot commented Sep 21, 2018

Codecov Report

Merging #550 into master will increase coverage by 0.41%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #550      +/-   ##
==========================================
+ Coverage   75.93%   76.35%   +0.41%     
==========================================
  Files           9       42      +33     
  Lines         798     2906    +2108     
==========================================
+ Hits          606     2219    +1613     
- Misses        118      482     +364     
- Partials       74      205     +131
Impacted Files Coverage Δ
beacon-chain/node/node.go 59.14% <0%> (ø) ⬆️
validator/beacon/service.go 93.27% <100%> (ø)
validator/node/node.go 45.87% <50%> (ø)
shared/p2p/service.go 67.01% <0%> (ø)
beacon-chain/utils/clock.go 100% <0%> (ø)
beacon-chain/types/active_state.go 75.47% <0%> (ø)
beacon-chain/rpc/service.go 92.42% <0%> (ø)
validator/attester/service.go 100% <0%> (ø)
validator/params/config.go 100% <0%> (ø)
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a455baa...6209800. Read the comment docs.

Copy link
Member

@terencechain terencechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Straightforward fix. Thanks for doing this!

@rauljordan rauljordan merged commit e9ae09e into prysmaticlabs:master Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants