Add HasBlock to verify parent check
#5478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
added
Ready For Review
0xKiwi
previously approved these changes
Apr 17, 2020
rauljordan
previously approved these changes
Apr 17, 2020
Codecov Report
@@ Coverage Diff @@
## master #5478 +/- ##
==========================================
+ Coverage 16.00% 23.33% +7.32%
==========================================
Files 7 234 +227
Lines 406 20060 +19654
==========================================
+ Hits 65 4680 +4615
- Misses 325 14482 +14157
- Partials 16 898 +882 |
prestonvanloon
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5477
Added
beaconDB.HasBlocktoverifyBlkPreStatecheck. This fixed an edge case that request parent blocks syncing at time epoch 0 encounteredThe alternative work around is to always
--force-clear-dbwhen syncing and the chain is before epoch 1