Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Geth Logging #5474

Merged
merged 8 commits into from
Apr 18, 2020
Merged

Add Geth Logging #5474

merged 8 commits into from
Apr 18, 2020

Conversation

nisdas
Copy link
Member

@nisdas nisdas commented Apr 17, 2020

We allow geth logging to be enabled for discoveryV5 in trace .

@nisdas nisdas requested a review from a team as a code owner April 17, 2020 11:24
@nisdas nisdas added the Ready For Review A pull request ready for code review label Apr 17, 2020
terencechain
terencechain previously approved these changes Apr 17, 2020
beacon-chain/main.go Outdated Show resolved Hide resolved
terencechain
terencechain previously approved these changes Apr 17, 2020
@@ -20,6 +20,7 @@ go_library(
"//shared/featureconfig:go_default_library",
"//shared/logutil:go_default_library",
"//shared/version:go_default_library",
"@com_github_ethereum_go_ethereum//log:go_default_library",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this to docker image deps too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok done

@prylabs-bulldozer prylabs-bulldozer bot merged commit b0af12d into master Apr 18, 2020
@delete-merged-branch delete-merged-branch bot deleted the gethLogging branch April 18, 2020 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants