Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validator activation to slasher #5472

Closed
wants to merge 3 commits into from

Conversation

shayzluf
Copy link
Contributor

[Part of] #5040


Description

store validator activation epoch in cache

@shayzluf shayzluf requested a review from a team as a code owner April 17, 2020 08:28
@shayzluf shayzluf added the Ready For Review A pull request ready for code review label Apr 17, 2020
@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #5472 into master will decrease coverage by 24.08%.
The diff coverage is 77.27%.

@@             Coverage Diff             @@
##           master    #5472       +/-   ##
===========================================
- Coverage   39.29%   15.20%   -24.09%     
===========================================
  Files         238      116      -122     
  Lines       20839     8887    -11952     
===========================================
- Hits         8188     1351     -6837     
+ Misses      11123     7370     -3753     
+ Partials     1528      166     -1362     

@shayzluf
Copy link
Contributor Author

closing this issue as i found that the proposed design doesn't rely on the spec. namely validators can attest to epochs no matter what their activation epoch is

@shayzluf shayzluf closed this Apr 17, 2020
@rauljordan rauljordan deleted the add_validator_activation_to_slasher branch October 13, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review A pull request ready for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant