Fix Network Encoder #5435
Merged
Fix Network Encoder #5435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
added
Ready For Review
prestonvanloon
approved these changes
Apr 15, 2020
Codecov Report
@@ Coverage Diff @@
## master #5435 +/- ##
===========================================
+ Coverage 28.46% 41.53% +13.07%
===========================================
Files 236 236
Lines 20224 20124 -100
===========================================
+ Hits 5757 8359 +2602
+ Misses 13499 10230 -3269
- Partials 968 1535 +567 |
61 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the network encoder defaulted to framed snappy encoding for both rpc and gossip messages. This PR clearly separates it so that rpc messages use framed snappy encoding and gossip messages use snappy block encoding