Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Validate For Metadata #5348

Merged
merged 3 commits into from
Apr 8, 2020
Merged

Fix Validate For Metadata #5348

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6e2934
return true
nisdas Apr 8, 2020
41f89ea
shay's review
nisdas Apr 8, 2020
626fb4f
Merge refs/heads/v0.11 into fixValidate
prylabs-bulldozer[bot] Apr 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion beacon-chain/sync/rpc_ping.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ func (r *Service) validateSequenceNum(seq uint64, id peer.ID) (bool, error) {
return false, err
}
if md == nil {
return false, nil
return true, nil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would expect the bool value to be the opposite

func (r *Service) validateSequenceNum(seq uint64, id peer.ID) (bool, error) {
	md, err := r.p2p.Peers().Metadata(id)
	if err != nil {
		return **false**, err
	}
	if md == nil {
		return **false**, nil
	}
	if md.SeqNumber != seq {
		return **false**, nil
	}
	return **true**, nil
}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok done

}
if md.SeqNumber != seq {
return true, nil
Expand Down