Clear init sync blocks on the correct line #5294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…init-sync-batch-save
…bs/prysm into disable-init-sync-batch-save
0xKiwi
approved these changes
Apr 2, 2020
Codecov Report
@@ Coverage Diff @@
## master #5294 +/- ##
==========================================
- Coverage 54.68% 23.59% -31.1%
==========================================
Files 304 230 -74
Lines 23980 19282 -4698
==========================================
- Hits 13113 4549 -8564
- Misses 9029 13870 +4841
+ Partials 1838 863 -975 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out github had issue the last hour, and the one last commit I pushed to #5281 didn't make it remote
This PR recreates that commit, it clears init sync blocks cache before a node retrieves the block to avoid getting a nil block