Add HighestSlotStatesBelow DB getter
#5213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5213 +/- ##
=========================================
Coverage ? 47.05%
=========================================
Files ? 229
Lines ? 18776
Branches ? 0
=========================================
Hits ? 8835
Misses ? 8440
Partials ? 1501 |
nisdas
reviewed
Mar 26, 2020
| ctx, span := trace.StartSpan(ctx, "BeaconDB.statesAtSlotBitfieldIndex") | ||
| defer span.End() | ||
|
|
||
| highestSlot := index - 1 |
There was a problem hiding this comment.
what if index is 0, this overflows
There was a problem hiding this comment.
addressed the line below :)
highestSlot = int(math.Max(0, float64(highestSlot)))
There was a problem hiding this comment.
wouldn't
math.Max(0, float64(highestSlot))
return the larger number which will be MaxFloat64 ?
There was a problem hiding this comment.
Nice catch! It's now taking int instead of uint64, also verified via a test. Thank you :)
nisdas
approved these changes
Mar 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
HighestSlotStatesBelowDB getter and tests.Last piece of DB feature to be used by new state mgmt and gen service 🙌