Update head slot metric after compute head #4754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nisdas
approved these changes
Feb 5, 2020
rauljordan
approved these changes
Feb 5, 2020
Codecov Report
@@ Coverage Diff @@
## master #4754 +/- ##
=========================================
Coverage ? 43.79%
=========================================
Files ? 203
Lines ? 15361
Branches ? 0
=========================================
Hits ? 6728
Misses ? 7499
Partials ? 1134 |
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* Update head slot after compute head * Merge branch 'master' into properly-update-head-metric * Merge refs/heads/master into properly-update-head-metric
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* Update head slot after compute head * Merge branch 'master' into properly-update-head-metric * Merge refs/heads/master into properly-update-head-metric
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it weird the reporting of
head_slotis always one slot behind versus proto array's service reporting. It turns out we updatehead_slotmetric before computing for head slot. We should updatehead_slotmetric after computing and this PR fixed that.