Fix Stuck Beacon Node #4454

nisdas · 2020-01-08T02:01:03Z

Reverts Revert #4392 #4449
Request blocks from the 1st deposit log instead of the 1st eth1 block.
Add contract deployment block flag.

Resolves #4482

This reverts commit 67c380b.

codecov · 2020-01-08T02:09:10Z

Codecov Report

❗ No coverage uploaded for pull request base (master@0bb6cf6). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4454   +/-   ##
=========================================
  Coverage          ?   47.71%           
=========================================
  Files             ?      208           
  Lines             ?    14522           
  Branches          ?        0           
=========================================
  Hits              ?     6929           
  Misses            ?     6462           
  Partials          ?     1131

…clabs/geth-sharding into revert-4449-revert-4392

shayzluf · 2020-01-14T06:57:02Z

beacon-chain/powchain/block_reader_test.go

@@ -42,6 +43,8 @@ func TestLatestMainchainInfo_OK(t *testing.T) {
 		t.Fatalf("unable to setup web3 ETH1.0 chain service: %v", err)
 	}
 	web3Service = setDefaultMocks(web3Service)
+	web3Service.rpcClient = &mockPOW.RPCClient{Backend: testAcc.Backend}
+


Suggested change

* Revert "Revert prysmaticlabs#4392 (prysmaticlabs#4449)" This reverts commit 67c380b. * bound start req * Merge refs/heads/master into revert-4449-revert-4392 * fix test * Merge branch 'revert-4449-revert-4392' of https://github.com/prysmaticlabs/geth-sharding into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * add flag for deployment block * Merge branch 'revert-4449-revert-4392' of https://github.com/prysmaticlabs/geth-sharding into revert-4449-revert-4392 * use constant and comments * lint * skip test for now * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Update shared/params/config.go Co-Authored-By: terence tsao <terence@prysmaticlabs.com> * Update beacon-chain/powchain/testing/mock.go Co-Authored-By: terence tsao <terence@prysmaticlabs.com> * preston's review * Merge branch 'revert-4449-revert-4392' of https://github.com/prysmaticlabs/geth-sharding into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * add flag * Merge branch 'revert-4449-revert-4392' of https://github.com/prysmaticlabs/geth-sharding into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * use stateutils * Merge branch 'revert-4449-revert-4392' of https://github.com/prysmaticlabs/geth-sharding into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392 * Merge refs/heads/master into revert-4449-revert-4392

Revert "Revert #4392 (#4449)"

08c00a1

This reverts commit 67c380b.

bound start req

c8b7d33

nisdas added the Ready For Review A pull request ready for code review label Jan 8, 2020

nisdas marked this pull request as ready for review January 8, 2020 02:12

Merge refs/heads/master into revert-4449-revert-4392

3ed0834

rauljordan previously approved these changes Jan 8, 2020

View reviewed changes

nisdas added 2 commits January 8, 2020 10:54

fix test

1f2e174

Merge branch 'revert-4449-revert-4392' of https://github.com/prysmati…

9eb6258

…clabs/geth-sharding into revert-4449-revert-4392

nisdas dismissed rauljordan’s stale review via 9eb6258 January 8, 2020 02:54

prylabs-bulldozer bot added 20 commits January 8, 2020 13:54

Merge refs/heads/master into revert-4449-revert-4392

8d07262

Merge refs/heads/master into revert-4449-revert-4392

c98fc33

Merge refs/heads/master into revert-4449-revert-4392

5da9892

Merge refs/heads/master into revert-4449-revert-4392

a1ba70e

Merge refs/heads/master into revert-4449-revert-4392

494b0a3

Merge refs/heads/master into revert-4449-revert-4392

1fa7004

Merge refs/heads/master into revert-4449-revert-4392

3f30238

Merge refs/heads/master into revert-4449-revert-4392

ce67e00

Merge refs/heads/master into revert-4449-revert-4392

cbbf39a

Merge refs/heads/master into revert-4449-revert-4392

89b0417

Merge refs/heads/master into revert-4449-revert-4392

89431ec

Merge refs/heads/master into revert-4449-revert-4392

4846a67

Merge refs/heads/master into revert-4449-revert-4392

1b95200

Merge refs/heads/master into revert-4449-revert-4392

cd8752f

Merge refs/heads/master into revert-4449-revert-4392

2d27762

Merge refs/heads/master into revert-4449-revert-4392

3a4bd84

Merge refs/heads/master into revert-4449-revert-4392

15e9bce

Merge refs/heads/master into revert-4449-revert-4392

f0e8895

Merge refs/heads/master into revert-4449-revert-4392

d1766d5

Merge refs/heads/master into revert-4449-revert-4392

625aa9c

nisdas and others added 14 commits January 13, 2020 22:35

Merge branch 'revert-4449-revert-4392' of https://github.com/prysmati…

2ebdcfd

…clabs/geth-sharding into revert-4449-revert-4392

Merge refs/heads/master into revert-4449-revert-4392

13bd261

Merge refs/heads/master into revert-4449-revert-4392

1c3b835

Merge refs/heads/master into revert-4449-revert-4392

f2994eb

Merge refs/heads/master into revert-4449-revert-4392

7b3f73b

Merge refs/heads/master into revert-4449-revert-4392

f6731ed

Merge refs/heads/master into revert-4449-revert-4392

aa9127a

Merge refs/heads/master into revert-4449-revert-4392

98c5fc7

Merge refs/heads/master into revert-4449-revert-4392

61e73dd

Merge refs/heads/master into revert-4449-revert-4392

72b0e5d

Merge refs/heads/master into revert-4449-revert-4392

4a52ee2

Merge refs/heads/master into revert-4449-revert-4392

c6df1fb

Merge refs/heads/master into revert-4449-revert-4392

d4b82cc

Merge refs/heads/master into revert-4449-revert-4392

4f6fe83

shayzluf reviewed Jan 14, 2020

View reviewed changes

prylabs-bulldozer bot added 9 commits January 14, 2020 16:05

Merge refs/heads/master into revert-4449-revert-4392

f7ce2ee

Merge refs/heads/master into revert-4449-revert-4392

3209d6d

Merge refs/heads/master into revert-4449-revert-4392

9eb9f29

Merge refs/heads/master into revert-4449-revert-4392

86c41b5

Merge refs/heads/master into revert-4449-revert-4392

aef80fa

Merge refs/heads/master into revert-4449-revert-4392

393b28d

Merge refs/heads/master into revert-4449-revert-4392

4bb7cf0

Merge refs/heads/master into revert-4449-revert-4392

0bb6cf6

Merge refs/heads/master into revert-4449-revert-4392

00d2d00

terencechain approved these changes Jan 16, 2020

View reviewed changes

prestonvanloon approved these changes Jan 16, 2020

View reviewed changes

prylabs-bulldozer bot merged commit 2e5429c into master Jan 16, 2020

delete-merged-branch bot deleted the revert-4449-revert-4392 branch January 16, 2020 01:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Stuck Beacon Node #4454

Fix Stuck Beacon Node #4454

nisdas commented Jan 8, 2020 •

edited by rauljordan

Loading

codecov bot commented Jan 8, 2020 •

edited

Loading

shayzluf Jan 14, 2020

Fix Stuck Beacon Node #4454

Fix Stuck Beacon Node #4454

Conversation

nisdas commented Jan 8, 2020 • edited by rauljordan Loading

codecov bot commented Jan 8, 2020 • edited Loading

Codecov Report

shayzluf Jan 14, 2020

Choose a reason for hiding this comment

nisdas commented Jan 8, 2020 •

edited by rauljordan

Loading

codecov bot commented Jan 8, 2020 •

edited

Loading