Persist ETH1 Information #4305
Merged
Persist ETH1 Information #4305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4305 +/- ##
========================================
Coverage ? 49.6%
========================================
Files ? 180
Lines ? 12731
Branches ? 0
========================================
Hits ? 6315
Misses ? 5427
Partials ? 989 |
| message LatestETH1Data { | ||
| uint64 block_height = 2; | ||
| uint64 block_time = 3; | ||
| repeated bytes block_hash = 4; |
There was a problem hiding this comment.
do we need ssz-size tag for this?
There was a problem hiding this comment.
we do not need it, we are just using protobufs to serialize this for disk storage.
|
Can you please add the purpose of the Eth1ChainData message in the description? |
|
Added in a comment on it @terencechain |
terencechain
previously approved these changes
Dec 17, 2019
beacon-chain/db/kv/powchain.go
Outdated
| @@ -0,0 +1 @@ | |||
| package kv | |||
There was a problem hiding this comment.
+1 on this package name, it can be specified in the .proto file
prestonvanloon
approved these changes
Dec 18, 2019
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* add data structures * generate proto * add in new fields * Merge branch 'master' of https://github.com/prysmaticlabs/geth-sharding into saveETH1Data * add comments * Merge branch 'master' into saveETH1Data * remove file * Merge branch 'saveETH1Data' of https://github.com/prysmaticlabs/geth-sharding into saveETH1Data * Merge branch 'master' into saveETH1Data * Merge branch 'master' into saveETH1Data * Merge refs/heads/master into saveETH1Data * Merge refs/heads/master into saveETH1Data
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* add data structures * generate proto * add in new fields * Merge branch 'master' of https://github.com/prysmaticlabs/geth-sharding into saveETH1Data * add comments * Merge branch 'master' into saveETH1Data * remove file * Merge branch 'saveETH1Data' of https://github.com/prysmaticlabs/geth-sharding into saveETH1Data * Merge branch 'master' into saveETH1Data * Merge branch 'master' into saveETH1Data * Merge refs/heads/master into saveETH1Data * Merge refs/heads/master into saveETH1Data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1430
Eth1ChainDatais used represent all our eth1 chain data so that it can be serialized for persistent storage.