Removed active count and shuffling cache #4266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4266 +/- ##
==========================================
+ Coverage 9.94% 42.45% +32.5%
==========================================
Files 76 50 -26
Lines 5109 3550 -1559
==========================================
+ Hits 508 1507 +999
+ Misses 4538 1844 -2694
- Partials 63 199 +136 |
0xKiwi
reviewed
Dec 12, 2019
shared/testutil/block_test.go
Outdated
| @@ -45,7 +44,7 @@ func TestGenerateFullBlock_ThousandValidators(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestGenerateFullBlock_Passes4Epochs(t *testing.T) { | |||
| helpers.ClearAllCaches() | |||
|
|
|||
There was a problem hiding this comment.
Are these empty lines at the start of the function intentional? I think we usually don't have an empty line at the start of a function.
There was a problem hiding this comment.
I agree with you, the new lines show inconsistency. Fixed in the latest commit
0xKiwi
reviewed
Dec 12, 2019
| @@ -1299,7 +1274,6 @@ func TestVerifyIndexedAttestation_OK(t *testing.T) { | |||
| } | |||
|
|
|||
| for _, tt := range tests { | |||
| helpers.ClearAllCaches() | |||
|
|
|||
There was a problem hiding this comment.
Can you remove this line also? Or is putting a empty line after the for loop usual? I see it done sometimes, sometimes not. I prefer it without the empty line.
0xKiwi
reviewed
Dec 12, 2019
| @@ -107,7 +107,6 @@ func TestUnslashedAttestingIndices_DuplicatedAttestations(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestAttestingBalance_CorrectBalance(t *testing.T) { | |||
| helpers.ClearAllCaches() | |||
|
|
|||
0xKiwi
reviewed
Dec 12, 2019
| @@ -1216,7 +1194,6 @@ func TestConvertToIndexed_OK(t *testing.T) { | |||
| }, | |||
| } | |||
| for _, tt := range tests { | |||
| helpers.ClearAllCaches() | |||
|
|
|||
0xKiwi
reviewed
Dec 12, 2019
| @@ -315,7 +310,7 @@ func TestBaseReward_AccurateRewards(t *testing.T) { | |||
| {40 * 1e9, params.BeaconConfig().MaxEffectiveBalance, 2862174}, | |||
| } | |||
| for _, tt := range tests { | |||
| helpers.ClearAllCaches() | |||
|
|
|||
0xKiwi
reviewed
Dec 12, 2019
| @@ -97,7 +96,6 @@ func TestProcessSlashingsPrecompute_SlashedLess(t *testing.T) { | |||
|
|
|||
| for i, tt := range tests { | |||
| t.Run(string(i), func(t *testing.T) { | |||
| helpers.ClearAllCaches() | |||
|
|
|||
0xKiwi
reviewed
Dec 12, 2019
| @@ -100,7 +99,6 @@ func TestExecuteStateTransition_FullProcess(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestProcessBlock_IncorrectProposerSlashing(t *testing.T) { | |||
| helpers.ClearAllCaches() | |||
|
|
|||
0xKiwi
reviewed
Dec 12, 2019
shared/testutil/helpers_test.go
Outdated
| @@ -11,7 +11,6 @@ import ( | |||
| ) | |||
|
|
|||
| func TestBlockSignature(t *testing.T) { | |||
| helpers.ClearAllCaches() | |||
|
|
|||
0xKiwi
reviewed
Dec 12, 2019
| @@ -419,7 +411,6 @@ func TestProcessSlashings_SlashedLess(t *testing.T) { | |||
|
|
|||
| for i, tt := range tests { | |||
| t.Run(string(i), func(t *testing.T) { | |||
| helpers.ClearAllCaches() | |||
|
|
|||
0xKiwi
reviewed
Dec 12, 2019
| @@ -37,7 +37,6 @@ func TestExecuteStateTransition_IncorrectSlot(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestExecuteStateTransition_FullProcess(t *testing.T) { | |||
| helpers.ClearAllCaches() | |||
|
|
|||
0xKiwi
reviewed
Dec 12, 2019
| @@ -181,7 +178,6 @@ func TestProcessBlock_IncorrectProcessBlockAttestations(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestProcessBlock_IncorrectProcessExits(t *testing.T) { | |||
| helpers.ClearAllCaches() | |||
|
|
|||
0xKiwi
approved these changes
Dec 12, 2019
7 tasks
|
Please deprecate the feature flags. |
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 24, 2020
* Removed * All tests pass * Gaz * Removed new lines * A few more lines... * I think i got them all * and I didnt : ) * Could this be last...
cryptomental
pushed a commit
to cryptomental/prysm
that referenced
this pull request
Feb 28, 2020
* Removed * All tests pass * Gaz * Removed new lines * A few more lines... * I think i got them all * and I didnt : ) * Could this be last...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #4264
This PR removed unused
active count cacheandshuffling cacheChange list:
helpers.ClearAllCaches(), it's no longer needed