Guard against deleting genesis and finalized state in DB #3842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3842 +/- ##
===========================================
+ Coverage 5.77% 42.05% +36.27%
===========================================
Files 3 160 +157
Lines 277 10555 +10278
===========================================
+ Hits 16 4439 +4423
- Misses 260 5383 +5123
- Partials 1 733 +732 |
terencechain
changed the title
beacon-chain/db/kv/state.go
Outdated
| genesisBlockRoot := bkt.Get(genesisBlockRootKey) | ||
| // Safe guard against deleting genesis or finalized state. | ||
| if bytes.Equal(blockRoot[:], finalizedCheckpt.Root) || bytes.Equal(blockRoot[:], genesisBlockRoot) { | ||
| return nil |
prestonvanloon
previously approved these changes
Oct 24, 2019
beacon-chain/db/kv/state.go
Outdated
| @@ -104,8 +105,21 @@ func (k *Store) SaveState(ctx context.Context, state *pb.BeaconState, blockRoot | |||
| func (k *Store) DeleteState(ctx context.Context, blockRoot [32]byte) error { | |||
| ctx, span := trace.StartSpan(ctx, "BeaconDB.DeleteState") | |||
| defer span.End() | |||
|
|
|||
| finalizedCheckpt, err := k.FinalizedCheckpoint(ctx) | |||
There was a problem hiding this comment.
Can you do this in the batch tx? it would make it faster with batch processing / go routines
prestonvanloon
previously approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list:
SaveFinalizedCheckpointandrmStatesBySlotsDeleteStateagainst deleting genesis and finalized statesResolves #3841